Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GitHub workflow 'nightly': bump Mac OS version #10348

Merged
merged 1 commit into from
Nov 4, 2024

Conversation

deining
Copy link
Contributor

@deining deining commented Nov 3, 2024

The macOS 12 Actions runner image will be fully unsupported by 12/3/24. This PR addresses this by bumping os version to latest version 15.

Copy link
Collaborator

@tarleb tarleb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but maybe we should consider #6622 before merging.

@jgm
Copy link
Owner

jgm commented Nov 4, 2024

It's best to build on the oldest version we can (for compatibility), but in this case we don't have much of a choice.

@jgm jgm merged commit f01bdef into jgm:main Nov 4, 2024
9 of 12 checks passed
@tarleb
Copy link
Collaborator

tarleb commented Nov 4, 2024

The oldest supported version is now macos-13, should we use that?

@jgm
Copy link
Owner

jgm commented Nov 4, 2024

Yes, I'll change it to 13.
Besides, ghcup is missing on 15!

jgm added a commit that referenced this pull request Nov 4, 2024
(on release_candidate and nightly actions).
macos-13 is the oldest supported version.

See #10348.
@deining deining deleted the mac-os12-removal branch November 4, 2024 21:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants